]> dgit.raspbian.org Git - gnome-shell.git/commit
messageTray: Always remove destroyed banners
authorFlorian Müllner <fmuellner@gnome.org>
Thu, 8 Jul 2021 17:10:05 +0000 (19:10 +0200)
committerMarge Bot <marge-bot@gnome.org>
Tue, 13 Jul 2021 12:38:51 +0000 (12:38 +0000)
commit1f4eea12a53e2ee126e1eca58dfb6e875ae3b72e
tree3c2c164c5c539242c7f88e0e47ff85012243089e
parent850d2a33a88badabf5375d32595f31a386f9aa91
messageTray: Always remove destroyed banners

Currently we only mark the banner as removed if it is destroyed
while in SHOWN or SHOWING state, but not if we're already HIDING
(for example in response to `NotificationBanner::done-displaying`).

If this happens, we'll try to destroy the notification again at
the end of the transition, which leads to (harmless but annoying)
log spam since Notifications were turned into GObjects (that are
disposed when destroyed).

Address this by always marking destroyed banners as removed, while
still only triggering a state update while shown (or in the process
of being shown).

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4457

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1908>
js/ui/messageTray.js